[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: heimdal 0.3d ftp client

>>>>> "Love" == Love  <lha@stacken.kth.se> writes:

    Love> You should check that the port-value was parsed ok (that is,
    Love> using strtol). If that fails you should use
    Love> getservbyname(port, "tcp") to see if it was valid port-name.

well... ok, but my patch was only designed to fix a specific bug, not
to add new features.

Then again, I am surprised this isn't already done.

    Love> Then you'll need to check for tcp-port == 0, since it's
    Love> reserved, and I'll guess the user will be confused when the
    Love> connection comes from <Dynamic and/or Private Ports> range
    Love> when they specifed 0 as port. That is what happens when you
    Love> bind to port 0, it seems to me that is just a silly way of
    Love> not specifying the port at all.

This bit confuses me.

Are you saying that there are programs that call ftp as

ftp hostname 0

and expect it to turn port 0 into port 21 (returned by
getservbyname("ftp", "tcp"))?

I won't argue with this, but not convinced it is really required
Brian May <bam@snoopy.apana.org.au>