[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Found some strange code

in kadmin/ext.c

    char *keytab = NULL;
    struct ext_keytab_data data;

    args[0].value = &keytab;

We set a global variable to the address of a local one.

the patch solves this by setting keytab to be static.
diff -Nur heimdal-0.6/kadmin/ext.c heimdal-0.6a/kadmin/ext.c
--- heimdal-0.6/kadmin/ext.c	2002-02-11 15:29:52.000000000 +0100
+++ heimdal-0.6a/kadmin/ext.c	2003-10-08 21:18:51.000000000 +0200
@@ -86,7 +86,7 @@
     krb5_error_code ret;
     int i;
     int optind = 0;
-    char *keytab = NULL;
+    static char *keytab = NULL;
     struct ext_keytab_data data;
     
     args[0].value = &keytab;