[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] FHS done right

6 dec 2007 kl. 01.54 skrev Hai Zaar:

> On Dec 6, 2007 5:39 AM, Love Hörnquist Åstrand <lha@kth.se> wrote:
>> Hej
>>> I've updated FHS patch to work properly - everything relocatable.
>>> Introduced --with-dbdir option to specify database location. Example
>>> ./configure --prefix=/usr --with-dbdir=/var/lib/heimdal
>> I think the source for info documentation should not be build in
>> configure.
>> Why don't you using variables and build a small "paths.info" file  
>> from
>> configure and include that in the info files and use info variables
>> instead.
> I've never wrote a singe .info page. I just do not know how to do it.
> Would anyone help?

Sure, just dead after skiing a whole day yesterday, otherwise I would
have countered with a patch.

>> Same goes for mdoc documentation, but I don't really know what to do
>> about that in a saner way. At least you should not use  
>> but rather a sed statement, autoconf-people dont like you when you do
>> that.
> I do not like sed, its dangerous. Also, files are not re-sed'ed when
> you make changes and run
> make. I know this looks a bit awkward, but I do not see brighter
> solution as well.
>>> DBDIR defaults to /var/heimdal to mimic old behavior.
>>> Also, no more hardcoded /var/* paths in .c and .h files.
>> roken-common.h is an installed headerfile, you can't have config.h
>> typ, it needs to be moved to roken.h or something else.
> Well, I'm not familiar with the code. I can offer roken-common.h.in.
> Do you like it?

roken.h is the built file, it should be done in that file instead, it  
almost be as simple as move the statement over there (almost).